Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor DaskIndexingAdapter __getitem__ method #8758

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Feb 15, 2024

this pull request removes the "unnecessary optimization" introduced in #3588 that attempts to rewrite the indexer key for BasicIndexer and OuterIndexer

@andersy005 andersy005 marked this pull request as ready for review February 15, 2024 21:46
@andersy005 andersy005 requested a review from dcherian February 15, 2024 21:46
@andersy005 andersy005 added the run-benchmark Run the ASV benchmark workflow label Feb 15, 2024
xarray/tests/test_dask.py Outdated Show resolved Hide resolved
@andersy005 andersy005 enabled auto-merge (squash) February 15, 2024 22:03
@andersy005 andersy005 removed the run-benchmark Run the ASV benchmark workflow label Feb 15, 2024
@dcherian dcherian disabled auto-merge February 15, 2024 22:44
@dcherian dcherian merged commit ff0d056 into pydata:main Feb 15, 2024
27 of 28 checks passed
@andersy005 andersy005 deleted the remove-dask-short-circuit branch February 15, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow performance with groupby using a custom DataArray grouper
2 participants