-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New alignment option: join='strict'
#8698
Closed
etienneschalk
wants to merge
27
commits into
pydata:main
from
etienneschalk:eschalk/issue-8231-align
Closed
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
bbe7d05
New alignment option: join='strict'
etienneschalk cddcaa1
Fix what's new newlines + retrigger CI
etienneschalk 37a7b09
wrong join
etienneschalk a93e44b
Merge branch 'main' into eschalk/issue-8231-align
etienneschalk ed4873e
Merge branch 'main' into eschalk/issue-8231-align
etienneschalk c6b1df5
Added test align 2d three arrays
etienneschalk ed0414a
Added tests and use assert_identical
etienneschalk a8bc8dc
Merge branch 'main' into eschalk/issue-8231-align
etienneschalk 451c96f
Merge branch 'main' into eschalk/issue-8231-align
etienneschalk f46b19b
Added tests for join=exact
etienneschalk 95295d1
Try replacing join=strict by broadcast=False
etienneschalk 80f5e1b
Merge branch 'eschalk/issue-8231-align' of github.com:etienneschalk/x…
etienneschalk d84c688
More broadcasts
etienneschalk 06c2077
Merge branch 'main' into eschalk/issue-8231-align
etienneschalk a7148d6
CI failed: mypy + warnings
etienneschalk 3a4e81a
Review - revert useless change
etienneschalk 4247a86
Review - missing passed down param, useless newline
etienneschalk 9db7db1
Apply suggestions from code review
etienneschalk 9966d4e
Merge branch 'eschalk/issue-8231-align' of github.com:etienneschalk/x…
etienneschalk e4d0a84
review - error message
etienneschalk fe56de8
Review - Use dims
etienneschalk e4b0cd8
param test
etienneschalk 6a4db7b
Merge branch 'main' into eschalk/issue-8231-align
etienneschalk 26d7311
Remove faulty line whats-new
etienneschalk df8fd3a
Review - remove broadcast from apply_ufunc
etienneschalk 651289f
Re-add missing line
etienneschalk 5cc61b0
Merge branch 'main' into eschalk/issue-8231-align
etienneschalk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being unclear (again). I don't think we need this in
align
at all.We should simply be checking
OPTIONS["arithmetic_broadcast"]
inVariable._binary_op
. The whole business withalign
was a misunderstanding of mine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will close this PR as it diverged too much from the original wanted behavior