Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce redundancy between namedarray and variable tests #8405

Merged
merged 13 commits into from
Nov 28, 2023

Conversation

maxrjones
Copy link
Contributor

Proof of concept for namedarray test structure proposed in #8370

@maxrjones maxrjones marked this pull request as draft November 21, 2023 16:35
@maxrjones maxrjones marked this pull request as ready for review November 21, 2023 18:16
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me 👍🏽! thank you, @maxrjones

@andersy005 andersy005 enabled auto-merge (squash) November 28, 2023 06:14
@andersy005 andersy005 merged commit d3a1527 into pydata:main Nov 28, 2023
27 of 28 checks passed
@maxrjones maxrjones deleted the namedarray-test-inheritance branch November 28, 2023 14:38
dcherian added a commit to rabernat/xarray that referenced this pull request Nov 29, 2023
* upstream/main:
  Raise an informative error message when object array has mixed types (pydata#4700)
  Start renaming `dims` to `dim` (pydata#8487)
  Reduce redundancy between namedarray and variable tests (pydata#8405)
  Fix Zarr region transpose (pydata#8484)
  Refine rolling_exp error messages (pydata#8485)
  Use numbagg for `ffill` by default (pydata#8389)
  Fix bug for categorical pandas index with categories with EA dtype (pydata#8481)
  Improve "variable not found" error message (pydata#8474)
  Add whatsnew for pydata#8475 (pydata#8478)
  Allow `rank` to run on dask arrays (pydata#8475)
  Fix mypy tests (pydata#8476)
  Use concise date format when plotting (pydata#8449)
  Fix `map_blocks` docs' formatting (pydata#8464)
  Consolidate `_get_alpha` func (pydata#8465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants