[skip-ci] Add benchmarks for Dataset binary ops, chunk #8351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Illviljan
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Looks good!
A small thought but since the CI benchmark has started to run for more than an hour nowadays I wonder if we should try and reduce the time somehow.
In the scope of catching open_dataset chunking performance we have that already so in that case it is a little redundant.
Although open_dataset also have other functions that can slow it down so maybe a more targeted version is also good?
This was my thinking. This really tests the core piece. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #8339
xref #8350