Request to adjust pyright config #8329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would it be possible to not have this config? It overrides the local VS Code config, and means VS Code constantly is reporting errors for me. Totally open to other approaches ofc. Or that we decide that the tradeoff is worthwhile
|
Are we even using this anymore? Everything seems to be commented out... |
|
No strong opinion here. I think the idea was that mypy does the same, but those we explicitly override. |
|
OK. I'll merge because it does make my development experience worse. But if we start using it, my personal preferences should obv be subsumed. (Or if there's another way so that it's override-able locally...) |
dcherian
added a commit
to max-sixty/xarray
that referenced
this pull request
Oct 19, 2023
* upstream/main: Docs: Add syntax for registering backends in `pyproject.toml` (pydata#8331) Request to adjust pyright config (pydata#8329)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would it be possible to not have this config? It overrides the local VS Code config, and means VS Code constantly is reporting errors for me.
Totally open to other approaches ofc. Or that we decide that the tradeoff is worthwhile