-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move parallelcompat and chunkmanagers to NamedArray #8319
Move parallelcompat and chunkmanagers to NamedArray #8319
Conversation
thank you for doing this work, @TomNicholas! moving these modules unblock me.
👍🏽 i concur. and yes, |
Moving Also moving the entrypoint seems to have broken the discovery of the |
This works in the CI! But it still breaks my local environment 🙁 I suspect this means it will break other developer's local environments too. The problem is these zombie entrypoints that I cannot seem to get rid of (even after deleting the In [1]: from importlib.metadata import entry_points
In [2]: entry_points().get("xarray.chunkmanagers", ())
Out[2]:
(EntryPoint(name='dask', value='xarray.namedarray.daskmanager:DaskManager', group='xarray.chunkmanagers'),
EntryPoint(name='dask', value='xarray.core.daskmanager:DaskManager', group='xarray.chunkmanagers'),
EntryPoint(name='dask', value='xarray.namedarray.daskmanager:DaskManager', group='xarray.chunkmanagers')) |
this is ready for another round of review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve my own PR, but I approve! 👍
@dcherian I got to this point before realizing that simply moving
parallelcompat.py
over isn't what it says in the design doc, which instead talks aboutI personally think that simply moving parallelcompat makes sense so long as you expect people to use chunked
NamedArray
objects. I see the chunked arrays as special cases of duck arrays, and my understanding is thatNamedArray
is supposed to have full support for duckarrays.cc @andersy005
Tests addedUser visible changes (including notable bug fixes) are documented inwhats-new.rst
New functions/methods are listed inapi.rst