Enable numbagg for reductions #8316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
approved these changes
Oct 16, 2023
xarray/core/nputils.py
Outdated
| except ImportError: | ||
| # use numpy methods instead | ||
| numbagg = np | ||
| _NUMBAGG_AVAILABLE = False |
There was a problem hiding this comment.
FYI there's a version of this at
xarray/xarray/core/rolling_exp.py
Lines 16 to 17 in dafd726
(though I'm not sure my approach is that good! Open to feedback...)
andersy005
approved these changes
Oct 16, 2023
andersy005
added
plan to merge
|
Waiting on numbagg/numbagg#162 to be released so I can add a version check and only defer to numbagg when |
Done! |
|
Should work whenever the CI environment updates. |
max-sixty
added a commit
to max-sixty/xarray
that referenced
this pull request
Oct 17, 2023
Uses the approach in pydata#8316, a bit nicer. Only internal.
max-sixty
added a commit
to max-sixty/xarray
that referenced
this pull request
Oct 17, 2023
Uses the approach in pydata#8316, a bit nicer. Only internal.
max-sixty
approved these changes
Oct 17, 2023
max-sixty
added a commit
that referenced
this pull request
Oct 19, 2023
* internal: Improve version handling for numbagg Uses the approach in #8316, a bit nicer. Only internal. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update xarray/core/rolling_exp.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rst