Convert indexes.py to use Self for typing
#8217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted to do this separately, as it's the only one that adds some casts. And given the ratio of impact-to-potential-merge-conflicts, I didn't want to slow the other PR down, even if it seems to be OK.
for more information, see https://pre-commit.ci
headtr1ck
reviewed
Sep 20, 2023
Co-authored-by: Michael Niklas <[email protected]>
Co-authored-by: Michael Niklas <[email protected]>
Co-authored-by: Michael Niklas <[email protected]>
Illviljan
changed the title
Variable to use Self for typingindexes.py to use Self for typing
headtr1ck
approved these changes
Sep 20, 2023
Co-authored-by: Michael Niklas <[email protected]>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to do this separately from #8216 , as it's the only one that adds a couple
ignores. And given the ratio of impact-to-potential-merge-conflicts, I didn't want to slow the other PR down.