Add T_DuckArray type hint to Variable.data #8203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is really annoying. Sorry for marking this @Illviljan, somehow the GitHub App does thing's without intention. |
Illviljan
changed the title
for more information, see https://pre-commit.ci
|
Yay, green mypy! Some solutions are taken from #8075. |
andersy005
approved these changes
Sep 19, 2023
|
Merging quickly to unblock anderson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typing of Variable.data has been the very wide
Variable.data: Anybecause of the difficulties defining the typing of a duckarray.This has led to confusion in downstream functions that uses
.data. Sometimes arguments uses Any, np.typing.ArrayLike, np.ndarray or dask array typing which is unnecessarily narrow when xarray also supports for example sparse arrays or cupy arrays.This PR is a start at cleaning this up by defining a T_DuckArray typevar that symbolizes an array api compliant array.