Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow creating DataArrays with nD coordinate variables #8126

Merged
merged 10 commits into from
Sep 22, 2023
Merged

Allow creating DataArrays with nD coordinate variables #8126

merged 10 commits into from
Sep 22, 2023

Conversation

dcherian
Copy link
Contributor

cc @blaylockbk

@dcherian dcherian mentioned this pull request Aug 31, 2023
Closed
4 tasks
@dcherian dcherian requested a review from benbovy September 8, 2023 15:58
@dcherian dcherian marked this pull request as ready for review September 8, 2023 15:59
headtr1ck
headtr1ck approved these changes Sep 10, 2023
View reviewed changes
Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

xarray/tests/test_dataarray.py Outdated Show resolved Hide resolved
xarray/tests/test_dataarray.py Outdated Show resolved Hide resolved
xarray/tests/test_dataarray.py Outdated Show resolved Hide resolved
xarray/tests/test_dataarray.py Outdated Show resolved Hide resolved
@headtr1ck headtr1ck added the plan to merge Final call for comments label Sep 10, 2023
dcherian
dcherian commented Sep 19, 2023
View reviewed changes
xarray/tests/test_dataarray.py
@@ -7085,3 +7082,32 @@ def test_error_on_ellipsis_without_list(self) -> None:
da = DataArray([[1, 2], [1, 2]], dims=("x", "y"))
with pytest.raises(ValueError):
da.stack(flat=...) # type: ignore


def test_nD_coord_dataarray() -> None:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benbovy can you review these tests please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gentle ping @benbovy

benbovy
benbovy approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@benbovy benbovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks @dcherian

@dcherian dcherian merged commit cdf0726 into pydata:main Sep 22, 2023
24 checks passed
@dcherian dcherian deleted the nD-coords-dataarray branch September 22, 2023 12:48
@dcherian dcherian mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@headtr1ck headtr1ck headtr1ck approved these changes

@benbovy benbovy benbovy approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plotting accessor error for datasets with Dimension name matches coordinate names
4 participants
@dcherian @benbovy @headtr1ck @max-sixty