Adds dask lock capability for backend writes #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2016
| @@ -161,8 +161,12 @@ def add(self, source, target): | |||
|
|
|||
| def sync(self): | |||
| if self.sources: | |||
| import dask.array as da | |||
| da.store(self.sources, self.targets) | |||
| import dask, dask.array as da | |||
There was a problem hiding this comment.
Please keep each import to its own line
|
This is going to be hard to test, but honestly I don't think that's essential given the simplicity of this code -- the complexity is buried upstream in dask, which does have comprehensive tests. If you do want to write a test for this, you could mock out a fake DataStore similar to what we wrote for the dask tests and turn on multi-threading. But I think that's probably overkill here. |
This fixes an error on an asynchronous write for `to_netcdf` resulting in an `dask.async.RuntimeError: NetCDF: HDF error` Resolves issue pydata#793 following dask improvement at dask/dask#1053 following advice of @shoyer.
pwolfram
force-pushed
the
dask_async_lock_fix
branch
from
5cca26a
to
759db6e
Compare
|
Thanks @shoyer for the review. I agree regarding this being simple enough to not require testing so this PR is probably ready to go. |
shoyer
added a commit
that referenced
this pull request
Mar 22, 2016
Adds dask lock capability for backend writes
|
Thanks @pwolfram ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error on an asynchronous write for
to_netcdfresulting in an
dask.async.RuntimeError: NetCDF: HDF errorResolves issue #793
following dask improvement at dask/dask#1053
following advice of @shoyer.