Move absolute path finder from open_mfdataset to own function #7968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Illviljan
changed the title
headtr1ck
approved these changes
Jul 9, 2023
| else: | ||
| paths = sorted(glob(_normalize_path(paths))) | ||
| elif isinstance(paths, os.PathLike): | ||
| paths = [os.fspath(paths)] |
There was a problem hiding this comment.
I know that this is just moved from the previous location, but is there a reason why we don't convert to absolute path here and below?
There was a problem hiding this comment.
I'm not sure, it's a little odd to me as well.
I haven't really felt the need for os.PathLike in my normal usage so I don't have much experience with that part though.
Co-authored-by: Michael Niklas <[email protected]>
|
@Illviljan see also xarray-contrib/datatree#51 |
|
@TomNicholas I've found the current open_datatree implementations too focused on zarr and netcdf. Which is fine, it's the most popular after all. |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Jul 16, 2023
* main: Remove hue_style from plot1d docstring (pydata#7925) Add new what's new section (pydata#7986) Release summary for v2023.07.0 (pydata#7979) Improve explanation in example "Working with Multidimensional Coordinates" (pydata#7984) Fix typo in zarr.py (pydata#7983) Examples added to docstrings (pydata#7936) [pre-commit.ci] pre-commit autoupdate (pydata#7973) Skip broken tests on python 3.11 and windows (pydata#7972) Use another repository for upstream testing (pydata#7970) Move absolute path finder from open_mfdataset to own function (pydata#7968) ensure no forward slashes in names for HDF5-based backends (pydata#7953) Chunked array docs (pydata#7951) [pre-commit.ci] pre-commit autoupdate (pydata#7959) manually unshallow the repository on RTD (pydata#7961) Update minimum version of typing extensions in pre-commit (pydata#7960) Docstring examples (pydata#7881)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple refactor to make it easier to retrieve the proper paths that
open_mfdatasetuses and passes on the engine.I've been thinking how to make use of DataTree and one idea I wanted to try was:
_find_absolute_path).xr.open_mfdataset(..., group=group)