Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duck array documentation improvements #7911

Merged
merged 41 commits into from
Jun 29, 2023

Conversation

TomNicholas
Copy link
Member

@TomNicholas TomNicholas commented Jun 12, 2023

Draft improvements to the user guide page on using duck arrays.

Intended as part of the scipy tutorial effort, though I wasn't sure whether to concentrate on content in the main xarray docs or the tutorial repo.

(I wrote this on a train without enough internet to update my conda environment so I will come back and fix anything that doesn't run.)

cc @dcherian and @keewis

@TomNicholas TomNicholas added topic-documentation topic-arrays related to flexible array support labels Jun 12, 2023
@github-actions github-actions bot removed the topic-arrays related to flexible array support label Jun 12, 2023
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomNicholas

doc/internals/duck-arrays-integration.rst Outdated Show resolved Hide resolved
doc/internals/duck-arrays-integration.rst Outdated Show resolved Hide resolved
doc/internals/duck-arrays-integration.rst Outdated Show resolved Hide resolved
doc/internals/duck-arrays-integration.rst Outdated Show resolved Hide resolved
doc/internals/duck-arrays-integration.rst Outdated Show resolved Hide resolved
doc/user-guide/duckarrays.rst Outdated Show resolved Hide resolved
doc/user-guide/duckarrays.rst Outdated Show resolved Hide resolved
doc/user-guide/duckarrays.rst Outdated Show resolved Hide resolved
doc/user-guide/duckarrays.rst Show resolved Hide resolved
doc/user-guide/duckarrays.rst Outdated Show resolved Hide resolved
@TomNicholas TomNicholas added the topic-arrays related to flexible array support label Jun 27, 2023
@TomNicholas TomNicholas requested a review from dcherian June 28, 2023 14:05
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Tom, this is a great addition. Just some minor comments.

doc/internals/duck-arrays-integration.rst Outdated Show resolved Hide resolved
doc/internals/duck-arrays-integration.rst Outdated Show resolved Hide resolved
doc/internals/duck-arrays-integration.rst Outdated Show resolved Hide resolved
doc/internals/duck-arrays-integration.rst Outdated Show resolved Hide resolved
doc/internals/index.rst Show resolved Hide resolved
doc/user-guide/duckarrays.rst Outdated Show resolved Hide resolved
doc/user-guide/duckarrays.rst Outdated Show resolved Hide resolved
doc/user-guide/duckarrays.rst Show resolved Hide resolved
doc/user-guide/duckarrays.rst Outdated Show resolved Hide resolved
doc/user-guide/duckarrays.rst Outdated Show resolved Hide resolved
Co-authored-by: Deepak Cherian <[email protected]>
@github-actions github-actions bot removed the topic-arrays related to flexible array support label Jun 28, 2023
@TomNicholas TomNicholas mentioned this pull request Jun 28, 2023
4 tasks
@TomNicholas TomNicholas enabled auto-merge (squash) June 29, 2023 14:38
@TomNicholas TomNicholas disabled auto-merge June 29, 2023 14:38
@TomNicholas TomNicholas merged commit 4b54421 into pydata:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants