Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix polyfit changing the original object #7900

Merged
merged 3 commits into from
Jun 9, 2023
Merged

fix polyfit changing the original object #7900

merged 3 commits into from
Jun 9, 2023

Conversation

malmans2
Copy link
Contributor

@malmans2 malmans2 commented Jun 7, 2023 •
edited
Loading

New functions/methods are listed in api.rst

@malmans2
Copy link
Contributor Author

malmans2 commented Jun 7, 2023 •
edited
Loading

I don't think the small change in the curvefit doctest is caused by this PR.
I get the same error using main.
The doctest error is unrelated to this PR: #7893

I've updated what's new in a separate commit, but looks like GH PRs are having difficulties at the moment.

@dcherian dcherian added the plan to merge Final call for comments label Jun 7, 2023
headtr1ck
headtr1ck approved these changes Jun 8, 2023
View reviewed changes
xarray/tests/test_dataset.py Show resolved Hide resolved
@dcherian dcherian merged commit 25b9ec8 into pydata:main Jun 9, 2023
dstansby pushed a commit to dstansby/xarray that referenced this pull request Jun 28, 2023
@malmans2 @dstansby
fix polyfit changing the original object (pydata#7900)
0994032 
* fix polyfit changing the original object

* what's new

* add test comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

@headtr1ck headtr1ck headtr1ck approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

polyfit with weights alters the DataArray in place
3 participants
@malmans2 @dcherian @headtr1ck