-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump minimum versions, drop py38 #7461
Conversation
Co-authored-by: Justus Magin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems fine to me, but I didn't check the typing / h5netcdf parts too closely
I have very few time lately but I should be able to have a look in the next few days of you can wait a bit longer. |
Thanks @jhamman |
Hi, |
`xarray` changed its minimum python version to 3.9 in 2023.2: pydata/xarray#7461 but a "fix" (version cap) for `pandas` was introduced in `xarray` version 2023.2, which will not be installed on python 3.8 setups. Pip/conda will happily pull the latest `pandas` version (now 2.x which is incompatible with `xarray`). To remedy the situation, manually downgrades the `pandas` version for the Py38 CI setup.
Here is our support policy for versions: https://docs.xarray.dev/en/stable/getting-started-guide/installing.html#minimum-dependency-versions though I think we dropped py38 too early. For your current issue, I'm surprised this patch didn't fix it: conda-forge/conda-forge-repodata-patches-feedstock#429 |
Hi @dcherian
I assume you have given this a lot of thought, but imho the minimum dependency versions should be decided according to features needed, not timing.
Thanks for the pointer.
|
It's not based on timing. |
Hi,
That's not how I interpret the link given by @dcherian, which states "rolling" minimum versions based on age. |
This also breaks xarray on ubuntu 20.04 which ships with Python 3.8 and is supported until April 2025. Python 3.8 is also supported at least until October 2024. Together with the Pandas 2 issue (that I am also running into), this is very unfortunate. |
Not investing effort to support 5 years old dependencies was a very conscious decision. This is not something unique we do; we simply adhere to NEP29: https://numpy.org/neps/nep-0029-deprecation_policy.html If for whatever reason you want to use python shipped by ubuntu 20.04, as opposed to conda/venv/poetry/whatever, you should also be prepared to stick to older versions of the python packages. Note that 5 years is the duration of security support. I'm not personally aware of security issues in xarray since Python 3.8 was abandoned (I've been a bit out of the loop and I could be proven wrong), but in the unlikely event that one should arise in xarray, we would consider a backport to Python 3.8. |
It just occurred to me that xarray dropped Python 3.8 3 months before what NEP-29 recommends. I think this is a problem. |
This updates our minimum versions based on our 24/18/12 month policy.
Details are shown below.
whats-new.rst