-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
absolufy-imports - Only in xarray folder #7370
Merged
dcherian
merged 10 commits into
pydata:main
from
Illviljan:aabsolufy_imports_no_asv_bench
Dec 9, 2022
Merged
absolufy-imports - Only in xarray folder #7370
dcherian
merged 10 commits into
pydata:main
from
Illviljan:aabsolufy_imports_no_asv_bench
Dec 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6e77f5e.
github-actions
bot
added
io
run-benchmark
Run the ASV benchmark workflow
topic-arrays
related to flexible array support
topic-backends
topic-CF conventions
topic-cftime
topic-combine
combine/concat/merge
topic-dask
topic-groupby
topic-html-repr
topic-indexing
topic-performance
topic-plotting
topic-rolling
topic-typing
topic-zarr
Related to zarr storage library
labels
Dec 8, 2022
github-actions
bot
removed
topic-typing
topic-backends
topic-html-repr
topic-combine
combine/concat/merge
topic-CF conventions
topic-indexing
topic-arrays
related to flexible array support
topic-plotting
io
labels
Dec 8, 2022
github-actions
bot
added
topic-dask
topic-groupby
topic-html-repr
topic-indexing
topic-plotting
topic-rolling
topic-typing
topic-zarr
Related to zarr storage library
labels
Dec 8, 2022
for more information, see https://pre-commit.ci
github-actions
bot
removed
topic-zarr
Related to zarr storage library
topic-dask
topic-typing
topic-rolling
topic-combine
combine/concat/merge
topic-backends
topic-plotting
topic-CF conventions
topic-cftime
topic-html-repr
topic-indexing
topic-groupby
io
topic-arrays
related to flexible array support
labels
Dec 8, 2022
Illviljan
changed the title
Revert "absolufy-imports - No relative imports - PEP8 (#7204)"
absolufy-imports - No relative imports - PEP8 - Only in xarray folder
Dec 8, 2022
Thanks for the quick fix @Illviljan |
dcherian
changed the title
absolufy-imports - No relative imports - PEP8 - Only in xarray folder
absolufy-imports - Only in xarray folder
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
plan to merge
Final call for comments
run-benchmark
Run the ASV benchmark workflow
topic-performance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts some of commit 6e77f5e and #7204.
Apparently using it on all folders is not a good idea, follow pandas example.