Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

absolufy-imports - Only in xarray folder #7370

Merged
merged 10 commits into from
Dec 9, 2022

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Dec 8, 2022

This reverts some of commit 6e77f5e and #7204.

Apparently using it on all folders is not a good idea, follow pandas example.

@Illviljan Illviljan changed the title Revert "absolufy-imports - No relative imports - PEP8 (#7204)" absolufy-imports - No relative imports - PEP8 - Only in xarray folder Dec 8, 2022
@Illviljan Illviljan marked this pull request as ready for review December 8, 2022 22:26
@Illviljan Illviljan added the plan to merge Final call for comments label Dec 9, 2022
@dcherian
Copy link
Contributor

dcherian commented Dec 9, 2022

Thanks for the quick fix @Illviljan

@dcherian dcherian changed the title absolufy-imports - No relative imports - PEP8 - Only in xarray folder absolufy-imports - Only in xarray folder Dec 9, 2022
@dcherian dcherian merged commit 7fc5022 into pydata:main Dec 9, 2022
@Illviljan Illviljan deleted the aabsolufy_imports_no_asv_bench branch December 10, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments run-benchmark Run the ASV benchmark workflow topic-performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants