Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Codecov #7142

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Fix Codecov #7142

merged 6 commits into from
Aug 30, 2023

Conversation

headtr1ck
Copy link
Collaborator

@headtr1ck
Copy link
Collaborator Author

@shoyer @max-sixty do you know who has rights to change the default branch to main on codecov.io?

@headtr1ck
Copy link
Collaborator Author

@max-sixty
Copy link
Collaborator

@shoyer @max-sixty do you know who has rights to change the default branch to main on codecov.io?

I just did this (and ofc happy to give you permission if it's helpful)

Though I still see the issue on mainhttps://app.codecov.io/gh/pydata/xarray/tree/main?displayType=list (not sure if we're expecting this to be better or not already?)

@rabernat
Copy link
Contributor

rabernat commented Feb 4, 2023

I just noticed our very low coverage rating and found this PR. Did this PR work? Should we update it and merge?

It would be great to have our coverage back in the 90s rather than the 50s 😝 .

@headtr1ck
Copy link
Collaborator Author

Unfortunately it does not work :/
It seems that something is going wrong with the flags.
I have opened an issue of codecov for this, but no results so far:
https://community.codecov.com/t/wrong-coverage-number-in-badge-with-flags/3975

Feel free to push the issue :)

@github-actions github-actions bot added the Automation Github bots, testing workflows, release automation label Aug 24, 2023
@headtr1ck
Copy link
Collaborator Author

I'm currently on holidays and mobile only.

@andersy005 thanks for looking into this, did your changes fix things?

You can also talk to Tom over at https://community.codecov.com/t/wrong-coverage-number-in-badge-with-flags

@andersy005
Copy link
Member

the badge is now displaying accurate coverage, although I'm not sure what fixed the issue

Code coverage

@andersy005 andersy005 marked this pull request as ready for review August 30, 2023 18:36
@andersy005 andersy005 enabled auto-merge (squash) August 30, 2023 18:38
@headtr1ck headtr1ck added the plan to merge Final call for comments label Aug 30, 2023
@headtr1ck
Copy link
Collaborator Author

the badge is now displaying accurate coverage, although I'm not sure what fixed the issue

Code coverage

But this is even fixed on the main branch? How is this possible?

@andersy005 andersy005 merged commit afda88e into pydata:main Aug 30, 2023
27 of 31 checks passed
@headtr1ck headtr1ck deleted the codecov branch August 30, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation Github bots, testing workflows, release automation plan to merge Final call for comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage shows reduced value since mypy flag was added
4 participants