Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dataset.assign_coords overwriting multi-index #7101

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

benbovy
Copy link
Member

@benbovy benbovy commented Sep 28, 2022

@dcherian the DeprecationWarning was ignored by default for .assign_coords() because of #6798 (comment). I changed it to FutureWarning so that it is shown for both .assign() and .assign_coords().

The `DeprecationWarning` is ignored by default for `.assign_coords` due
to the
stacklevel (pydata#6798 (comment))

Use `FutureWarning` instead to show the warning for both `.assign` and
`.assign_coords`.
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

@benbovy benbovy merged commit 513ee34 into pydata:main Sep 28, 2022
@benbovy benbovy deleted the fix-assign-coords-dataset-mindex branch December 8, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken state when using assign_coords with multiindex
2 participants