Improved DataArray typing #6637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
This is really great, thank you for all this work @headtr1ck ! |
Illviljan
reviewed
May 25, 2022
|
Should fix error nr.1 in #6576 |
|
This is huge, thanks @headtr1ck ! |
auto-merge was automatically disabled
May 27, 2022 06:32
Head branch was pushed to by a user without write access
|
Thanks, @headtr1ck! |
|
We could start setting up a lint for every function in There is a mypy lint for it IIRC, and I think it can be enabled on a subset of files. |
lstngr
pushed a commit
to lstngr/xarray
that referenced
this pull request
May 31, 2022
…docs Fixes merge with pydata#6637
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Jun 12, 2022
* main: (95 commits) Use `zarr` to validate attrs when writing to zarr (pydata#6636) Add pre-commit hook to check CITATION.cff (pydata#6658) Fix kwargs used for extrapolation in docs (pydata#6639) Fix notebooks' HTML links (pydata#6655) Doc index update (pydata#6530) CFTime support for polyval (pydata#6624) Support dask arrays in datetime_to_numeric (pydata#6556) [pre-commit.ci] pre-commit autoupdate (pydata#6654) 0-padded month. (pydata#6653) [test-upstream] import `cleanup` fixture from `distributed` (pydata#6650) Allow all interp methods in typing (pydata#6647) Typing support for custom backends (pydata#6651) Improved DataArray typing (pydata#6637) Adjust code comments & types from pydata#6638 (pydata#6642) Typing of `str` and `dt` accessors (pydata#6641) Feature/to dict encoding (pydata#6635) fix {full,zeros,ones}_like overloads (pydata#6630) Mypy badge (pydata#6626) concatenate docs style (pydata#6621) Typing for open_dataset/array/mfdataset and to_netcdf/zarr (pydata#6612) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves typing of
DataArrayclass methods.Main change is that
T_DataArrayis used whenever possible.I have left everything untouched that would cause problems with mypy (there are some mypy bugs) or require larger typing efforts in other areas.
Main problems are
argminandargmax.