pre-commit: autoupdate hook versions

[github-actions]

Base PullRequest

default branch (https://github.com/pydata/xarray/tree/main)

Command results

Details:

add path

/home/runner/work/_actions/technote-space/create-pr-action/837dbe469b39f08d416889369a52e2a993625c84/node_modules/npm-check-updates/bin

python -m pre_commit autoupdate

Updating https://github.com/pre-commit/pre-commit-hooks ... [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
already up to date.
Updating https://github.com/PyCQA/isort ... [INFO] Initializing environment for https://github.com/PyCQA/isort.
already up to date.
Updating https://github.com/psf/black ... [INFO] Initializing environment for https://github.com/psf/black.
already up to date.
Updating https://github.com/keewis/blackdoc ... [INFO] Initializing environment for https://github.com/keewis/blackdoc.
already up to date.
Updating https://gitlab.com/pycqa/flake8 ... [INFO] Initializing environment for https://gitlab.com/pycqa/flake8.
already up to date.
Updating https://github.com/pre-commit/mirrors-mypy ... [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy.
updating v0.910 -> v0.910-1.

python -m pre_commit run --all-files

[INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy:numpy,types-PyYAML,types-pkg_resources,types-python-dateutil,types-pytz,typing-extensions==3.10.0.0.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/PyCQA/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/psf/black.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/keewis/blackdoc.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://gitlab.com/pycqa/flake8.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check Yaml...............................................................Passed
isort....................................................................Passed
black....................................................................Passed
blackdoc.................................................................Passed
flake8...................................................................Passed
mypy.....................................................................Failed
- hook id: mypy
- exit code: 2

xarray/core/_typed_ops.py: error: Duplicate module named "xarray.core._typed_ops" (also at "xarray/core/_typed_ops.pyi")
xarray/core/_typed_ops.py: note: Are you missing an __init__.py? Alternatively, consider using --exclude to avoid checking one of them.
Found 1 error in 1 file (errors prevented further checking)

Changed files

Changed file:

• .pre-commit-config.yaml

---

Repo | 📝 Issues | 🏬 Marketplace

[keewis]

Just for reference, this is the output for pre-commit run --all-files (hidden in Command results → python -m pre_commit run --all-files):

[INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy:numpy,types-PyYAML,types-pkg_resources,types-python-dateutil,types-pytz,typing-extensions==3.10.0.0.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/PyCQA/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/psf/black.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/keewis/blackdoc.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://gitlab.com/pycqa/flake8.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check Yaml...............................................................Passed
isort....................................................................Passed
black....................................................................Passed
blackdoc.................................................................Passed
flake8...................................................................Passed
mypy.....................................................................Failed
- hook id: mypy
- exit code: 2

xarray/core/_typed_ops.py: error: Duplicate module named "xarray.core._typed_ops" (also at "xarray/core/_typed_ops.pyi")
xarray/core/_typed_ops.py: note: Are you missing an __init__.py? Alternatively, consider using --exclude to avoid checking one of them.
Found 1 error in 1 file (errors prevented further checking)

to avoid things like this we should probably replace our custom workflow with pre-commit.ci (and set autofix_prs: false).

[max-sixty]

Oh that's annoying. It's weird that it reported a success then?

Good find for pre-commit.ci. I'd be up for that

[max-sixty]

Hmmm, linting fails in #5849. I think maybe on this PR the checks just didn't run?

[keewis]

indeed, we can't trigger workflows from workflows (I think we'd need a separate access token for that?). It did run pre-commit run --all-files but the output is hidden in the "details" of the PR comment, so you actively have to check it to see whether something failed.