Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence some test warnings #5451

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Silence some test warnings #5451

merged 3 commits into from
Jun 9, 2021

Conversation

mathause
Copy link
Collaborator

@mathause mathause commented Jun 7, 2021

Silences a number of warnings that accumulated in our test suite (c.f. #3266). The changes are mostly unrelated but small.

max-sixty
max-sixty approved these changes Jun 7, 2021
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mathause !

mathause
mathause commented Jun 7, 2021
View reviewed changes
xarray/core/dataset.py Outdated Show resolved Hide resolved
@mathause mathause merged commit ff1fbf5 into pydata:master Jun 9, 2021
@mathause mathause deleted the silence_some_warnings branch June 9, 2021 17:27
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2021

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ff1fbf5. ± Comparison against base commit ff1fbf5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathause @max-sixty