Trigger CI on push or pull_request but not both #5142
Merged
+58
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersy005
commented
Apr 12, 2021
.github/workflows/ci.yaml
Outdated
Comment on lines
20
to
22
| concurrent_skipping: "same_content" | ||
| skip_after_successful_duplicate: "true" | ||
| do_not_skip: '["pull_request", "workflow_dispatch"]' |
There was a problem hiding this comment.
Incidentally, this action can be used to automatically skip CI runs for documentation related PRs (without needing to use the [skip-ci] in the commit message).
with:
paths_ignore: '["**/doc/**"]'Should we enable this?
There was a problem hiding this comment.
Should we enable this?
👍, it's really easy to forget adding that flag
keewis
approved these changes
Apr 19, 2021
|
Okay, I believe this is ready. I may have missed some corner cases (I'm happy to address these in separate PRs).
|
|
Thanks @andersy005 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesHere's a snippet of how this looks like when a pull request is created on the same main repository:
Cc @keewis