Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LazilyOuterIndexedArray alias to LazilyIndexedArray for external backends to use #5112

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Add LazilyOuterIndexedArray alias to LazilyIndexedArray for external backends to use #5112

merged 1 commit into from
Apr 6, 2021

Conversation

alexamici
Copy link
Collaborator

@mathause
Copy link
Collaborator

mathause commented Apr 5, 2021

Will the alias be kept or should you add a deprecation warning?

@alexamici
Copy link
Collaborator Author

I see quite a few uses "in the wild":

https://github.com/search?l=Python&q=LazilyOuterIndexedArray&type=Code

I would suggest to keep it long term to avoid migration pains to external backend developers.

@alexamici
Copy link
Collaborator Author

alexamici commented Apr 6, 2021

If nobody objects I'll merge this shortly as this breaks building against master of external projects testing out the backend-plugin infrastructure. We can always add a deprecation warning on a follow-up PR.

@alexamici alexamici merged commit 903278a into pydata:master Apr 6, 2021
@alexamici alexamici deleted the LazilyOuterIndexedArray-alias branch April 6, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename of LazilyOuterIndexedArray to LazilyIndexedArray breaks rioxarray
2 participants