Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the compatibility code in duck_array_ops.allclose_or_equiv #4270

Merged
merged 1 commit into from
Jul 26, 2020
Merged

remove the compatibility code in duck_array_ops.allclose_or_equiv #4270

merged 1 commit into from
Jul 26, 2020

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Jul 25, 2020 •
edited
Loading

#3847 added compatibility code for dask < 2.9.1. Since we bumped to 2.9 this code can be safely removed. If we can't require dask >= 2.9.1 yet, we can wait with the merge of this PR until we can bump dask again.

  • Passes isort . && black . && mypy . && flake8

@max-sixty
Copy link
Collaborator

Thanks @keewis !

dcherian
dcherian approved these changes Jul 25, 2020
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass!

@keewis
Copy link
Collaborator Author

keewis commented Jul 26, 2020

let's merge, then?

@keewis keewis merged commit 9d6b174 into pydata:master Jul 26, 2020
@keewis keewis deleted the remove-dask-compat-code branch July 26, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keewis @max-sixty @dcherian