Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the upstream-dev pandas build failure #4138

Merged
merged 6 commits into from
Jun 11, 2020

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Jun 10, 2020

As pointed out by @TomAugspurger in #4133 (comment), there are pre-built nightly wheels for numpy, scipy and pandas in the scipy-wheels-nightly repository.

Not sure how frequently these are updated, though, at least the numpy wheel doesn't really seem to be built daily.

@keewis keewis changed the title Fix upstream dev Fix the upstream-dev pandas build failure Jun 10, 2020
@keewis
Copy link
Collaborator Author

keewis commented Jun 10, 2020

I just noticed that the rackcdn.org repository doesn't have matplotlib>=3.2.0, so since about late February we don't test against matplotlib upstream anymore.

@max-sixty
Copy link
Collaborator

Thanks a lot for doing all these @keewis , I think we all appreciate the efforts. I hope to start helping again this summer.

@dcherian
Copy link
Contributor

__________________________________ test_chunk __________________________________

    @requires_dask
    def test_chunk():
        s = sparse.COO.from_numpy(np.array([0, 0, 1, 2]))
        a = DataArray(s)
        ac = a.chunk(2)
        assert ac.chunks == ((2, 2),)
>       assert isinstance(ac.data._meta, sparse.COO)
E       AssertionError: assert False
E        +  where False = isinstance(array([], dtype=int64), <class 'sparse._coo.core.COO'>)
E        +    where array([], dtype=int64) = dask.array<xarray-<this-array>, shape=(4,), dtype=int64, chunksize=(2,), chunktype=numpy.ndarray>._meta
E        +      where dask.array<xarray-<this-array>, shape=(4,), dtype=int64, chunksize=(2,), chunktype=numpy.ndarray> = <xarray.DataArray (dim_0: 4)>\ndask.array<xarray-<this-array>, shape=(4,), dtype=int64, chunksize=(2,), chunktype=numpy.ndarray>\nDimensions without coordinates: dim_0.data
E        +    and   <class 'sparse._coo.core.COO'> = sparse.COO

Test failures seem real and point to dask meta issues? Shall we merge this and open another issue for these sparse failures?

@keewis
Copy link
Collaborator Author

keewis commented Jun 11, 2020

there are also failures that don't seem to involve dask, so I guess this would be mostly a sparse issue?

👍 on merging, but I'd suggest opening two issues: one for the sparse failure and one to remind us to fix the matplotlib upstream-dev install

@dcherian
Copy link
Contributor

Sounds good. Thanks @keewis

@dcherian dcherian merged commit 4071125 into pydata:master Jun 11, 2020
@keewis keewis deleted the fix-upstream-dev branch June 11, 2020 10:10
dcherian added a commit to TomNicholas/xarray that referenced this pull request Jun 24, 2020
…o-combine

* 'master' of github.com:pydata/xarray: (81 commits)
  use builtin python types instead of the numpy alias (pydata#4170)
  Revise pull request template (pydata#4039)
  pint support for Dataset (pydata#3975)
  drop eccodes in docs (pydata#4162)
  Update issue templates inspired/based on dask (pydata#4154)
  Fix failing upstream-dev build & remove docs build (pydata#4160)
  Improve typehints of xr.Dataset.__getitem__ (pydata#4144)
  provide a error summary for assert_allclose (pydata#3847)
  built-in accessor documentation (pydata#3988)
  Recommend installing cftime when time decoding fails. (pydata#4134)
  parameter documentation for DataArray.sel (pydata#4150)
  speed up map_blocks (pydata#4149)
  Remove outdated note from datetime accessor docstring (pydata#4148)
  Fix the upstream-dev pandas build failure (pydata#4138)
  map_blocks: Allow passing dask-backed objects in args (pydata#3818)
  keep attrs in reset_index (pydata#4103)
  Fix open_rasterio() for WarpedVRT with specified src_crs (pydata#4104)
  Allow non-unique and non-monotonic coordinates in get_clean_interp_index and polyfit (pydata#4099)
  update numpy's intersphinx url (pydata#4117)
  xr.infer_freq (pydata#4033)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upstream-dev failure when installing pandas
3 participants