Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary comprehension #4026

Merged
merged 2 commits into from
May 5, 2020

Conversation

pnijhara
Copy link
Contributor

@pnijhara pnijhara commented May 4, 2020

  • Passes isort -rc . && black . && mypy . && flake8
  • Fully documented, including whats-new.rst for all changes and api.rst for new API

@max-sixty
Copy link
Collaborator

Thanks @pnijhara — want to add to whatsnew + give yourself credit? No problem if not given the breadth of the change.

@pnijhara
Copy link
Contributor Author

pnijhara commented May 4, 2020

@max-sixty, sorry! I am not getting you. Can you be more clearer?

@max-sixty
Copy link
Collaborator

If you like, you can add a line here: https://github.com/pydata/xarray/blob/master/doc/whats-new.rst, under "Internal Changes" to say you made a change. You don't have to, though.

@pnijhara
Copy link
Contributor Author

pnijhara commented May 4, 2020

Will surely write.
@max-sixty, Please review it again.

@pnijhara pnijhara force-pushed the pnijhara-patch-4 branch from fd70dcb to c71a77e Compare May 4, 2020 23:32
@max-sixty
Copy link
Collaborator

Thanks. Merging as the test failure is unrelated.

@max-sixty max-sixty merged commit 1b3c768 into pydata:master May 5, 2020
dcherian added a commit to kmuehlbauer/xarray that referenced this pull request May 9, 2020
…k-issues

* upstream/master: (22 commits)
  support darkmode (pydata#4036)
  Use literal syntax instead of function calls to create the data structure (pydata#4038)
  Add template xarray object kwarg to map_blocks (pydata#3816)
  Transpose coords by default (pydata#3824)
  Remove broken test for Panel with to_pandas() (pydata#4028)
  Allow warning with cartopy in docs plotting build (pydata#4032)
  Support overriding existing variables in to_zarr() without appending (pydata#4029)
  chore: Remove unnecessary comprehension (pydata#4026)
  fix to_netcdf docstring typo (pydata#4021)
  Pint support for DataArray (pydata#3643)
  Apply blackdoc to the documentation (pydata#4012)
  ensure Variable._repr_html_ works (pydata#3973)
  Fix handling of abbreviated units like msec (pydata#3998)
  full_like: error on non-scalar fill_value (pydata#3979)
  Fix some code quality and bug-risk issues (pydata#3999)
  DOC: add pandas.DataFrame.to_xarray (pydata#3994)
  Better chunking error messages for zarr backend (pydata#3983)
  Silence sphinx warnings (pydata#3990)
  Fix distributed tests on upstream-dev (pydata#3989)
  Add multi-dimensional extrapolation example and mention different behavior of kwargs in interp (pydata#3956)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants