Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKG: Explicitly add setuptools dependency #3628

Merged
merged 6 commits into from
Jan 30, 2020

Conversation

hoechenberger
Copy link
Contributor

Compare conda-forge/xarray-feedstock#53

Not sure whether this should be mentioned in whats-new.rst?

  • Fully documented, including whats-new.rst for all changes and api.rst for new API

@dcherian dcherian requested a review from crusaderky December 18, 2019 15:21
@dcherian
Copy link
Contributor

gentle ping @crusaderky

@crusaderky
Copy link
Contributor

setuptools is not a runtime dependency since #3720
Also, I'm confused - both conda and cpython always come with setuptools preinstalled. How did you manage to get an environment without it?

@hoechenberger
Copy link
Contributor Author

hoechenberger commented Jan 30, 2020

Also, I'm confused - both conda and cpython always come with setuptools preinstalled. How did you manage to get an environment without it?

It won't get auto-installed on the conda-forge CI, see conda-forge/xarray-feedstock#53 (comment)

@crusaderky crusaderky closed this Jan 30, 2020
@crusaderky crusaderky reopened this Jan 30, 2020
@crusaderky
Copy link
Contributor

@dcherian I've heavily changed this, please give it a second read and merge if you're happy with it

@crusaderky crusaderky requested a review from dcherian January 30, 2020 19:25
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK but i have no experience with configuring setup.cfg

@crusaderky crusaderky merged commit 95e4f6c into pydata:master Jan 30, 2020
@hoechenberger hoechenberger deleted the setuptools branch January 30, 2020 22:06
dcherian added a commit to dcherian/xarray that referenced this pull request Jan 31, 2020
* upstream/master:
  Python 3.8 CI (pydata#3727)
  PKG: Explicitly add setuptools dependency (pydata#3628)
  update whats-new
  Typo in Universal Functions section (pydata#3663)
  Release v0.15.0
  fix setup.cfg
  Documentation fixes (pydata#3732)
  Remove extra && in PR template (pydata#3730)
  Remove garbage text inserted in DASK_LICENSE (pydata#3729)
  Avoid unsafe use of pip (pydata#3726)
  remove PR pre-black instructions (pydata#3707)
  Fix whats-new for 0.15 (pydata#3723)
  Add isort to CI (pydata#3721)
  setuptools-scm (3) (pydata#3724)
  Fix Sphinx links on contributing doc page (pydata#3710)
dcherian added a commit to johnomotani/xarray that referenced this pull request Feb 24, 2020
…under

* upstream/master: (71 commits)
  Optimize isel for lazy array equality checking (pydata#3588)
  pin msgpack (pydata#3793)
  concat now handles non-dim coordinates only present in one dataset (pydata#3769)
  Add new h5netcdf backend phony_dims kwarg (pydata#3753)
  always use dask_array_type for isinstance calls (pydata#3787)
  allow formatting the diff of ndarray attributes (pydata#3728)
  Pint support for variables (pydata#3706)
  Format issue template comment as md comment (pydata#3790)
  Avoid running test_open_mfdataset_list_attr without dask (pydata#3780)
  remove seaborn.apionly compatibility (pydata#3749)
  Python 3.8 CI (pydata#3727)
  PKG: Explicitly add setuptools dependency (pydata#3628)
  update whats-new
  Typo in Universal Functions section (pydata#3663)
  Release v0.15.0
  fix setup.cfg
  Documentation fixes (pydata#3732)
  Remove extra && in PR template (pydata#3730)
  Remove garbage text inserted in DASK_LICENSE (pydata#3729)
  Avoid unsafe use of pip (pydata#3726)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants