Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DataArray.pad, Dataset.pad, Variable.pad #3596
Add DataArray.pad, Dataset.pad, Variable.pad #3596
Changes from 23 commits
7c230aa
5980234
b6a979b
80abc3a
ed3d88e
d4e484d
65d7495
0d7f1a7
1ee2950
11023c3
3aae4ba
742487e
314f007
7515478
ba3f0a4
855c39e
d507d1d
64ac8a2
71e11bb
7060b07
588ff03
3e6f792
6958da9
af0a4a1
f781f72
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I don't like it, but is is the way that most xarray functions handle this. Although I should add a check for
xarray.dtypes.NA
. We have discussed addingxarray.dtypes.NA
as the default value for the constant_values keyword. But unfortunately this kind of interferes with the fact that you cannot specify constant_values when you set the mode to anything other than "constant". So if you have any ideas, I'm all ears.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I think it currently works well now, but we should probably have a different example: passing
np.nan
is a mistake, and instead users can rely on the default and it'll coerce to float withdtypes.NA
implied.Is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. That looks to me like a reasonable default.