Fix duck array ops that were calling bottleneck on sparse arrays #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
min and max are now working. notnull was already fixed by one of my earlier PRs. std/var/median are still broken, but only because sparse hasn't implemented the corresponding NumPy functions yet (nanstd, nanvar and nanmedian). rank needs pure NumPy implementation (not via bottleneck) if we want it to work on sparse or dask arrays.
max-sixty
approved these changes
Aug 23, 2019
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Aug 26, 2019
* upstream/master: Initialize empty or full DataArray (pydata#3159) Raise on inplace=True (pydata#3260) added support for rasterio geotiff tags (pydata#3249) Remove sel_points (pydata#3261) Fix sparse ops that were calling bottleneck (pydata#3254) New feature of filter_by_attrs added (pydata#3259) Update filter_by_attrs to use 'variables' instead of 'data_vars' (pydata#3247)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min and max are now working.
notnull was already fixed by one of my earlier PRs.
std/var/median are still broken, but only because sparse hasn't implemented
the corresponding NumPy functions yet (nanstd, nanvar and nanmedian).
rank needs pure NumPy implementation (not via bottleneck) if we want it to
work on sparse or dask arrays.
black . && mypy . && flake8