Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_dict without data #2659

Merged
merged 5 commits into from
Jan 21, 2019
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion doc/io.rst
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,16 @@ require external libraries and dicts can easily be pickled, or converted to
json, or geojson. All the values are converted to lists, so dicts might
be quite large.

To export just the dataset schema, without the data itself, use the
``data=False`` option:

.. ipython:: python

ds.to_dict(data=False)

This can be useful for generating indices of dataset contents to expose to
search indices or other automated data discovery tools.

.. _io.netcdf:

netCDF
Expand Down Expand Up @@ -665,7 +675,7 @@ To read a consolidated store, pass the ``consolidated=True`` option to
:py:func:`~xarray.open_zarr`::

ds = xr.open_zarr('foo.zarr', consolidated=True)

Xarray can't perform consolidation on pre-existing zarr datasets. This should
be done directly from zarr, as described in the
`zarr docs <https://zarr.readthedocs.io/en/latest/tutorial.html#consolidating-metadata>`_.
Expand Down
2 changes: 2 additions & 0 deletions doc/whats-new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ Breaking changes
Enhancements
~~~~~~~~~~~~

- Add ``data=False`` option to ``to_dict()`` methods. (:issue:`2656`)
By `Ryan Abernathey <https://github.com/rabernat>`_
- :py:meth:`~xarray.DataArray.coarsen` and
:py:meth:`~xarray.Dataset.coarsen` are newly added.
See :ref:`comput.coarsen` for details.
Expand Down
22 changes: 10 additions & 12 deletions xarray/core/dataarray.py
Original file line number Diff line number Diff line change
Expand Up @@ -1759,7 +1759,7 @@ def to_netcdf(self, *args, **kwargs):

return dataset.to_netcdf(*args, **kwargs)

def to_dict(self):
def to_dict(self, data=True):
"""
Convert this xarray.DataArray into a dictionary following xarray
naming conventions.
Expand All @@ -1768,22 +1768,20 @@ def to_dict(self):
Useful for coverting to json. To avoid datetime incompatibility
use decode_times=False kwarg in xarrray.open_dataset.

Parameters
----------
data : bool, optional
Whether to include the actual data in the dictionary. When set to
False, returns just the schema.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be useful to allow including the data for the coordinates but not the data variables?

I'm thinking something like

ds.to_dict(data='coords')


See also
--------
DataArray.from_dict
"""
d = {'coords': {}, 'attrs': decode_numpy_dict_values(self.attrs),
'dims': self.dims}

d = self.variable.to_dict(data=data)
d.update({'coords': {}, 'name': self.name})
for k in self.coords:
data = ensure_us_time_resolution(self[k].values).tolist()
d['coords'].update({
k: {'data': data,
'dims': self[k].dims,
'attrs': decode_numpy_dict_values(self[k].attrs)}})

d.update({'data': ensure_us_time_resolution(self.values).tolist(),
'name': self.name})
d['coords'][k] = self.coords[k].variable.to_dict(data=data)
return d

@classmethod
Expand Down
21 changes: 9 additions & 12 deletions xarray/core/dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -3218,7 +3218,7 @@ def to_dask_dataframe(self, dim_order=None, set_index=False):

return df

def to_dict(self):
def to_dict(self, data=True):
"""
Convert this dataset to a dictionary following xarray naming
conventions.
Expand All @@ -3227,25 +3227,22 @@ def to_dict(self):
Useful for coverting to json. To avoid datetime incompatibility
use decode_times=False kwarg in xarrray.open_dataset.

Parameters
----------
data : bool, optional
Whether to include the actual data in the dictionary. When set to
False, returns just the schema.

See also
--------
Dataset.from_dict
"""
d = {'coords': {}, 'attrs': decode_numpy_dict_values(self.attrs),
'dims': dict(self.dims), 'data_vars': {}}

for k in self.coords:
data = ensure_us_time_resolution(self[k].values).tolist()
d['coords'].update({
k: {'data': data,
'dims': self[k].dims,
'attrs': decode_numpy_dict_values(self[k].attrs)}})
d['coords'].update({k: self[k].variable.to_dict(data=data)})
for k in self.data_vars:
data = ensure_us_time_resolution(self[k].values).tolist()
d['data_vars'].update({
k: {'data': data,
'dims': self[k].dims,
'attrs': decode_numpy_dict_values(self[k].attrs)}})
d['data_vars'].update({k: self[k].variable.to_dict(data=data)})
return d

@classmethod
Expand Down
11 changes: 10 additions & 1 deletion xarray/core/variable.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
from .options import _get_keep_attrs
from .pycompat import (
OrderedDict, basestring, dask_array_type, integer_types, zip)
from .utils import OrderedSet, either_dict_or_kwargs
from .utils import (OrderedSet, either_dict_or_kwargs,
decode_numpy_dict_values, ensure_us_time_resolution)

try:
import dask.array as da
Expand Down Expand Up @@ -408,6 +409,14 @@ def to_index(self):
"""Convert this variable to a pandas.Index"""
return self.to_index_variable().to_index()

def to_dict(self, data=True):
"""Dictionary representation of variable."""
item = {'dims': self.dims,
'attrs': decode_numpy_dict_values(self.attrs)}
if data:
item['data'] = ensure_us_time_resolution(self.values).tolist()
return item

@property
def dims(self):
"""Tuple of dimension names with which this variable is associated.
Expand Down
7 changes: 7 additions & 0 deletions xarray/tests/test_dataarray.py
Original file line number Diff line number Diff line change
Expand Up @@ -2909,6 +2909,13 @@ def test_to_and_from_dict(self):
ValueError, "cannot convert dict without the key 'data'"):
DataArray.from_dict(d)

# check the data=False option
expected_no_data = expected.copy()
del expected_no_data['data']
del expected_no_data['coords']['x']['data']
actual_no_data = array.to_dict(data=False)
assert expected_no_data == actual_no_data

def test_to_and_from_dict_with_time_dim(self):
x = np.random.randn(10, 3)
t = pd.date_range('20130101', periods=10)
Expand Down
15 changes: 12 additions & 3 deletions xarray/tests/test_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -3045,11 +3045,20 @@ def test_to_and_from_dict(self):
# check roundtrip
assert_identical(ds, Dataset.from_dict(actual))

# check the data=False option
expected_no_data = expected.copy()
print(expected_no_data)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a forgotten print here!

del expected_no_data['coords']['t']['data']
del expected_no_data['data_vars']['a']['data']
del expected_no_data['data_vars']['b']['data']
actual_no_data = ds.to_dict(data=False)
assert expected_no_data == actual_no_data

# verify coords are included roundtrip
expected = ds.set_coords('b')
actual = Dataset.from_dict(expected.to_dict())
expected_ds = ds.set_coords('b')
actual = Dataset.from_dict(expected_ds.to_dict())

assert_identical(expected, actual)
assert_identical(expected_ds, actual)

# test some incomplete dicts:
# this one has no attrs field, the dims are strings, and x, y are
Expand Down