Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flake check to travis #2632

Merged
merged 4 commits into from
Dec 30, 2018
Merged

Add flake check to travis #2632

merged 4 commits into from
Dec 30, 2018

Conversation

max-sixty
Copy link
Collaborator

@fujiisoup
Copy link
Member

Thanks, @max-sixty.
I personally like to have a separate CI to check pep8 violation, so that we can easily distinguish whether the tests or pep8 fail by the green check in the bottom.

Do you have any idea about the ci for pep8? Or we can simply use the general ci such as circle ci?

@max-sixty
Copy link
Collaborator Author

max-sixty commented Dec 25, 2018 •
edited
Loading

I tend to agree on the differentiation between code tests and formatting tests.

But I think setting up CircleCI / Azure might be a lot of lift for just the CI flake check?
Do people still have patience for Stickler?

I've at least added it as a separate check in Travis, though that doesn't show in GH

@shoyer shoyer merged commit 1545b50 into pydata:master Dec 30, 2018
@shoyer
Copy link
Member

shoyer commented Dec 30, 2018

If someone else can figure out how to setup these checks to run with another CI service that would be fantastic, but this is definitely an improvement over nothing at all.

@max-sixty max-sixty deleted the flake-check branch December 30, 2018 06:26
@fujiisoup fujiisoup mentioned this pull request Dec 30, 2018
Closed
dcherian pushed a commit to yohai/xarray that referenced this pull request Jan 2, 2019
Merge branch 'master' into yohai-ds_scatter
faf4302 
* master:
  DEP: drop python 2 support and associated ci mods (pydata#2637)
  TST: silence warnings from bottleneck (pydata#2638)
  revert to dev version
  DOC: fix docstrings and doc build for 0.11.1
  Source encoding always set when opening datasets (pydata#2626)
  Add flake check to travis (pydata#2632)
  Fix dayofweek and dayofyear attributes from dates generated by cftime_range (pydata#2633)
  silence import warning (pydata#2635)
  fill_value in shift (pydata#2470)
  Flake fixed (pydata#2629)
  Allow passing of positional arguments in `apply` for Groupby objects (pydata#2413)
  Fix failure in time encoding for pandas < 0.21.1 (pydata#2630)
  Fix multiindex selection (pydata#2621)
  Close files when CachingFileManager is garbage collected (pydata#2595)
  added some logic to deal with rasterio objects in addition to filepaths (pydata#2589)
  Get 0d slices of ndarrays directly from indexing (pydata#2625)
  FIX Don't raise a deprecation warning for xarray.ufuncs.{angle,iscomplex} (pydata#2615)
  CF: also decode time bounds when available (pydata#2571)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-sixty @fujiisoup @shoyer