Code

Feature: N-dimensional auto_combine#2553

Code

Merged

shoyer merged 40 commits intopydata:masterpydata/xarray:masterfrom TomNicholas:feature/nd_combineCopy head branch name to clipboardDec 13, 2018

+623-48

Commits

Commits on Nov 5, 2018

• concatenates along a single dimension

  TomNicholas

  committed
  88ee12a

Commits on Nov 7, 2018

• Wrote function to find correct tile_IDs from nested list of datasets

  TomNicholas

  committed
  1aaa075

• Wrote function to check that combined_tile_ids structure is valid

  TomNicholas

  committed
  dbb371d

• Added test of 2d-concatenation

  TomNicholas

  committed
  cc4d743

Commits on Nov 8, 2018

• Tests now check that dataset ordering is correct

  TomNicholas

  committed
  d2fc7e7

• Test concatentation along a new dimension

  TomNicholas

  committed
  e3f3699

Commits on Nov 9, 2018

• Started generalising auto_combine to N-D by integrating the N-D concatentation algorithm

  TomNicholas

  committed
  55bf685

Commits on Nov 10, 2018

• All unit tests now passing

  TomNicholas

  committed
  845206c

• Merge branch 'real_master' into feature/nd_combine

  TomNicholas

  committed
  fb66626

• Fixed a failing test which I didn't notice because I don't have pseudoNetCDF

  TomNicholas

  committed
  f4e9aad

Commits on Nov 14, 2018

• Began updating open_mfdataset to handle N-D input

  TomNicholas

  committed
  00004a1

• Refactored to remove duplicate logic in open_mfdataset & auto_combine

  TomNicholas

  committed
  b41e374

• Implemented Shoyers suggestion in #2553 to rewrite the recursive nested list traverser as an iterator

  TomNicholas

  committed
  8672a79

• --amend

  TomNicholas

  committed
  4f56b24

• Now raises ValueError if input not ordered correctly before concatenation

  TomNicholas

  committed
  4cfaf2e

Commits on Nov 22, 2018

• Added some more prototype tests defining desired behaviour more clearly

  TomNicholas

  committed
  9fd1413

Commits on Nov 24, 2018

• Now raises informative errors on invalid forms of input

  TomNicholas

  committed
  8ad0121

Commits on Nov 25, 2018

• Refactoring to alos merge along each dimension

  TomNicholas

  committed
  4b2c544

Commits on Nov 26, 2018

• Refactored to literally just apply the old auto_combine along each dimension

  TomNicholas

  committed
  3d0061e

• Added unit tests for open_mfdatset

  TomNicholas

  committed
  60c93ba

• Removed TODOs

  TomNicholas

  committed
  1824538

Commits on Nov 30, 2018

• Removed format strings

  TomNicholas

  committed
  d380815

• test_get_new_tile_ids now doesn't assume dicts are ordered

  TomNicholas

  committed
  c4bb8d0

• Fixed failing tests on python3.5 caused by accidentally assuming dict was ordered

  TomNicholas

  committed
  6b7f889

• Test for getting new tile id

  TomNicholas

  committed
  58a3648

• Fixed itertoolz import so that it's compatible with older versions

  TomNicholas

  committed
  a12a34a

Commits on Dec 1, 2018

• Increased test coverage

  TomNicholas

  committed
  ada1f4a

• Added toolz as an explicit dependency to pass tests on python2.7

  TomNicholas

  committed
  ef0a30e

• Updated 'what's new'

  TomNicholas

  committed
  3be70bc

• No longer attempts to shortcut all concatenation at once if concat_dims=None

  TomNicholas

  committed
  f266bc3

• Merge branch 'master' into feature/nd_combine

  TomNicholas

  authored
  cf49c2b

• Rewrote using itertools.groupby instead of toolz.itertoolz.groupby to remove hidden dependency on toolz

  TomNicholas

  committed
  878e1f9

• Merged changes from master

  TomNicholas

  committed
  7dea14f

• Fixed erroneous removal of utils import

  TomNicholas

  committed
  e6f25a3

Commits on Dec 2, 2018

• Updated docstrings to include an example of multidimensional concatenation

  TomNicholas

  committed
  f856485

Commits on Dec 5, 2018

• Clarified auto_combine docstring for N-D behaviour

  TomNicholas

  committed
  6305d83

Commits on Dec 10, 2018

• Added unit test for nested list of Datasets with different variables

  TomNicholas

  committed
  ce59da1

• Minor spelling and pep8 fixes

  TomNicholas

  committed
  9fb34cf

Commits on Dec 11, 2018

• Reverted API so that N-D generalisation is hidden

  TomNicholas

  committed
  f47486f

Commits on Dec 12, 2018

• Removed infer_order_from_coords argument

  TomNicholas

  committed
  ebbe47f