Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backend test classes so they actually run #2479

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Fix backend test classes so they actually run #2479

merged 2 commits into from
Oct 11, 2018

Commits on Oct 11, 2018

  1. Fix backend test classes so they actually run 

    We accidentally stopped running many backend tests when we merged GH2467,
because they no longer inherited from untitest.TestCase and didn't have a
name starting with "Test".

This PR renames the tests so they actually run. I also fixed a bug with the
pseudonetcdf backend that appears to have been introduced by a bad merge in
GH2261. It wasn't caught because the tests weren't actually running.
    @shoyer
    shoyer committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    827ab1d View commit details
    Browse the repository at this point in the history

  2. Fixup test_conventions.py

    @shoyer
    shoyer committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    84bf0d4 View commit details
    Browse the repository at this point in the history