Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/test build for python 3.7 #2271

Merged
merged 5 commits into from
Sep 22, 2018
Merged

dev/test build for python 3.7 #2271

merged 5 commits into from
Sep 22, 2018

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Jul 8, 2018 •
edited
Loading

  • Tests added
  • Tests passed (for all non-documentation changes)
  • Fully documented, including whats-new.rst for all changes and api.rst for new API

@jhamman
Copy link
Member Author

jhamman commented Jul 8, 2018 •
edited
Loading

It looks like travis isn't ready for 3.7 (travis-ci/travis-ci#9815). We can revisit in a few days. I did get a bare bones environment up and running with 3.7 and the minimal test suite passed, so that's a good sign.

@spencerahill spencerahill mentioned this pull request Jul 8, 2018
Closed
@jhamman
Copy link
Member Author

jhamman commented Sep 22, 2018

Python 3.7 tests seem happy now. I have a minimal environment setup for 3.7. It may be a bit until all the optional deps have 3.7 support so maybe we just merge this as is and migrate our more comprehensive test environments to 3.7 as needed.

@max-sixty max-sixty self-requested a review September 22, 2018 17:19
max-sixty
max-sixty approved these changes Sep 22, 2018
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jhamman !

@jhamman jhamman merged commit 04253f2 into pydata:master Sep 22, 2018
@shoyer
Copy link
Member

shoyer commented Sep 22, 2018

Nice, thanks!

To be honest, I don't know if there's any particular need to even specify a Python version with Travis, given that we use conda environments for everything.

@jhamman jhamman mentioned this pull request Sep 23, 2018
Merged
1 task
dcherian pushed a commit to dcherian/xarray that referenced this pull request Sep 23, 2018
Merge branch 'master' into contour-labels-kwarg
db20a54 
* master:
  dev/test build for python 3.7 (pydata#2271)
  misc plotting fixes (pydata#2426)
@jhamman jhamman mentioned this pull request Nov 5, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
topic-testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhamman @shoyer @max-sixty