Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow positional indexing with unsigned integer types #1544

Closed
wants to merge 1 commit into from
Closed

allow positional indexing with unsigned integer types #1544

wants to merge 1 commit into from

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Aug 31, 2017

cc @gerritholl

@jhamman jhamman mentioned this pull request Sep 1, 2017
Closed
4 tasks
@fujiisoup
Copy link
Member

I think this will conflict with #1473.
(In #1473, I removed canonicalize_indexer function).

Can I absorb this PR into #1473?

@jhamman
Copy link
Member Author

jhamman commented Sep 1, 2017

@fujiisoup - Yes, please do.

@jhamman jhamman mentioned this pull request Sep 1, 2017
Closed
4 tasks
@jhamman
Copy link
Member Author

jhamman commented Sep 1, 2017

I'm going to close this in lieu of #1473. Thanks @fujiisoup.

@jhamman jhamman closed this Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhamman @fujiisoup