Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.14.1 Release #3434

Closed
12 tasks done
crusaderky opened this issue Oct 22, 2019 · 18 comments
Closed
12 tasks done

v0.14.1 Release #3434

crusaderky opened this issue Oct 22, 2019 · 18 comments

Comments

@crusaderky
Copy link
Contributor

crusaderky commented Oct 22, 2019

I think with the multiple recent breakages we've just had due to dependency upgrades, we should push out a patch release with some haste.

Please comment/add/object

Must have

Nice to have

@dcherian
Copy link
Contributor

#3406 needs a review

@mathause
Copy link
Collaborator

Would be nice to get this out - just hit #3426. (I now updated to master but this is besides the point).

@crusaderky
Copy link
Contributor Author

@mathause I'm personally really uncomfortable pushing out a release when there are multiple known breakages against dependencies - see Must have list. Help is welcome!

@crusaderky
Copy link
Contributor Author

@barronh any update re pseudonetcdf 3.1?

@barronh
Copy link
Contributor

barronh commented Oct 31, 2019

I believe there are two issues here.

First, the 3.1 release was not 2.7 compliant. It mixed named keyword arguments with **kwds. That could be fixed easily.

Second, the camx reader changed subclasses, which affects the xarray test for CF variables. I could update the test that would fix xarray test-case.

@crusaderky
Copy link
Contributor Author

@barronh, we don't care about Python 2.7 compliance. We support >=3.6.

@barronh
Copy link
Contributor

barronh commented Nov 4, 2019

Got it. This is a test update to a test that is backward and forward compatible. I'll get something checked in.

@mathause
Copy link
Collaborator

mathause commented Nov 5, 2019

xref for numpy 1.18 numpy/numpy#14831

@dcherian
Copy link
Contributor

dcherian commented Nov 5, 2019

@mathause Thanks for filing these upstream issues!

@dcherian
Copy link
Contributor

dcherian commented Nov 7, 2019

Once #3491 is merged, we should be ready to release since numpy will fix itself (numpy/numpy#14841)

@mathause
Copy link
Collaborator

mathause commented Nov 7, 2019

Don't we have to figure out whether to use np.mean or np.nanmean for datetime vectors?

@dcherian
Copy link
Contributor

I'm in favour of releasing even if we are currently broken with numpy master.

Our current release is also broken with numpy master, so the situation is no worse...

@crusaderky crusaderky mentioned this issue Nov 15, 2019
3 tasks
@crusaderky
Copy link
Contributor Author

If someone could review and merge #3537 and #3531, we can close this!

@crusaderky
Copy link
Contributor Author

I think we're good to go!

@dcherian
Copy link
Contributor

I agree! @crusaderky, @max-sixty: do either of you have the time to make a release?

@max-sixty
Copy link
Collaborator

Yup I can do it later this afternoon!

@dcherian
Copy link
Contributor

👍

@dcherian
Copy link
Contributor

Thanks @max-sixty I activated the RTD build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants