Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ellipsis in place of xr.ALL_DIMS? #3414

Closed
max-sixty opened this issue Oct 18, 2019 · 2 comments
Closed

Allow ellipsis in place of xr.ALL_DIMS? #3414

max-sixty opened this issue Oct 18, 2019 · 2 comments

Comments

@max-sixty
Copy link
Collaborator

@crusaderky had a good idea to allow ellipsis (...) as a placeholder for 'other dims' in transpose.

What about using it as a placeholder for xr.ALL_DIMS in groupby etc operations? I find it nicer than custom sentinel values, and I think should be fairly low-confusion—thoughts?
@dcherian
Copy link
Contributor

Sounds great to me

@max-sixty max-sixty mentioned this issue Oct 19, 2019
Merged
3 tasks
@shoyer
Copy link
Member

shoyer commented Oct 20, 2019

+1 for setting ALL_DIMS = .... That's much more ergonomic.

@crusaderky crusaderky mentioned this issue Oct 22, 2019
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shoyer @dcherian @max-sixty