-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.13.0 release #3257
Comments
There are couple of small fixes for sparse arrays with open pull requests. I would lean toward getting those in before the release. One thing that would be especially helpful is finalizing some deprecations that have been open for a while, e.g., the removal of the inplace argument and sel_points(). |
Also it would be great if you’d like to try going through the release process. We can potentially automate and/or remove some of those steps. |
What do you think about writing a small script and deploying with an azure pipeline, triggering only on new tags? Could include the standard running tests etc. I'd need to look into how authentication re PyPI would work if done remotely. Or is this begging the xkcd cartoon? |
Given that's 1 hour of work about once a month... Unless there is appetite for increasing the release frequency, I would say automation is overkill |
This bit seems easily scriptable |
Yeah, automation is probably overkill if someone does it correctly each time – it does also mean hopefully no one makes a mistake / forgets a step |
My experience has been that the manual processes (e.g., checking release notes, finishing up deprecation cycles) take up most of the effort of issuing a new release. The commands 4-9 take about 5 minutes to run. I agree that the main value of automation there would be reducing the likelihood of manual mistakes. It looks like there's an experimental documentation builder for pull requests with read the docs. It would be interesting to explore using it in xarray: https://blog.readthedocs.com/building-docs-for-pull-requests/ |
Perfect - I emailed. Anything else like this, feel free to push onto us / me |
The benefit to automation also makes it easier to distribute the workload to other people, helping with project sustainability. On my projects, I find it very nice that I make a new release on GitHub and packages appear on PyPI and the web docs are automatically updated to the new version. |
How do you do this? i.e. trigger PyPI and RTD updates with a tag on github? |
On Travis I have some deploy hooks:
|
FYI: we're on the waitlist for the RTD feature |
FYI re RTD PR feature, too many PRs! :)
|
RTD is struggling with resources, and I can understand that. What is really annoying (and the problem is often the same on travis) is that the conda install is taking a huge part of the build process resources. See e.g. readthedocs/readthedocs.org#6025 , where I ended up using pip for very satisfying results (!). |
Can't we have a nightly build of docker images with all the xarray depencencies?
|
This would help on Travis yes, but not on RTD which doesn't support docker. But otherwise yes, I've also found that CI is faster and more reliable with docker. In terms of resources "in general", I wonder if it wouldn't be nice to share a common testing image base with other packages of the pydata ecosytem. |
I did some searching for "FutureWarning" and "DeprecationWarning", and turned up a bunch worth cleaning up for 0.13: Otherwise I think we're ready do a release? |
(FYI I am on vacation — can contribute next week) |
It would be nice to get #3239 in since it fixes a longstanding issue with open_mfdataset. |
We should also merge the |
Ideally there are a few things we should finish:
I agree it would be nice to get these into a release. On the other hand, I feel like most doc users are just looking at the "latest" docs, so perhaps not as urgent as the other items on here. |
I'm not so sure of this. The default is stable. and it isn't very obvious how to change it. We can also merge that branch multiple times... |
Yes, we can merge/rebase changes into "stable" even after cutting a release.
…On Tue, Sep 10, 2019 at 1:56 PM Deepak Cherian ***@***.***> wrote:
On the other hand, I feel like most doc users are just looking at the
"latest" docs
I'm not so sure of this. The default is stable. and it isn't very obvious
how to change it.
We can also merge that branch multiple times...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3257?email_source=notifications&email_token=AAJJFVV7GENIIQAJJHZ73VDQJACZPA5CNFSM4IPDKA22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6MO3VI#issuecomment-530116053>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJJFVTWYNFSRJMKFL3GOFDQJACZPANCNFSM4IPDKA2Q>
.
|
Anything final remaining? A couple of nice-to-haves on #3280 but otherwise I think all done? If so, I have some time this week to help—I can coordinate |
OK, @max-sixty or @dcherian do one of you want to take the lead on issuing the release this time? Everything should be in the |
OK happy to do so.
Do you want to add the rest of the core team as owners on pypi and RTD? |
Great—happy to help @dcherian—thank you! |
OK I've done everything but
@max-sixty Can you take over emailing the users list?
|
@shoyer instructions in HOW_TO_RELEASE worked perfectly :) |
@dcherian (and anyone else who's interested) could you please send me your pypi and RTD account names? |
Yes, and our Twitter account! Ping back when it's on PyPI and I'll send out |
@shoyer I'm at maximilianroos on PyPI but maybe we lock that down tighter than the GH privileges? |
Maintainers permissions enable: "Can upload releases for a package. Cannot add collaborators. Cannot delete files, releases, or the project." I'm pretty happy passing that out to anyone interested :) |
Hahaha, I just signed up at PyPI as dcherian EDIT: I'm dcherian on RTD also. |
@dcherian done! you should have permissions for both RTD and pypi now |
Thanks! Done with release on PyPI: https://pypi.org/project/xarray/0.13.0/ Time to announce! |
@dcherian did you add a tag? I don't see that yet |
Great! My mistake |
I just merged conda-forge/xarray-feedstock#50, so the release should be available on conda-forge soon. |
Success! Thanks team!
…On Tue, Sep 17, 2019 at 6:33 PM Maximilian Roos ***@***.***> wrote:
Closed #3257 <#3257>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3257?email_source=notifications&email_token=AAJJFVQP33UC653KRZMYI3DQKGAQBA5CNFSM4IPDKA22YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTV327OA#event-2641866680>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJJFVRON7ZYBJGXQN2NQDLQKGAQBANCNFSM4IPDKA2Q>
.
|
@pydata/xarray let me know any feedback on the email announcements |
What do we think about a minor release soon?
My colleague just hit #3145 which reminded me the current release can make filing an issue confusing for folks
We've had a v good pipeline of changes in just a month: https://github.com/pydata/xarray/blob/master/doc/whats-new.rst#L18
I'm happy to help with this; ref #2998 (comment)
The text was updated successfully, but these errors were encountered: