Skip to content

Commit

Permalink
review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
dcherian committed Oct 29, 2021
1 parent 7b3fb24 commit cc5a934
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions xarray/core/options.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ class T_Options(TypedDict):
enable_cftimeindex: bool
file_cache_maxsize: int
keep_attrs: Literal["default", True, False]
warn_for_unclosed_files: bool
use_bottleneck: bool
warn_for_unclosed_files: bool


else:
Expand Down Expand Up @@ -60,8 +60,8 @@ class T_Options(TypedDict):
enable_cftimeindex: bool
file_cache_maxsize: int
keep_attrs: Literal["default", True, False]
warn_for_unclosed_files: bool
use_bottleneck: bool
warn_for_unclosed_files: bool

except ImportError:
from typing import TYPE_CHECKING, Any, Dict, Hashable
Expand All @@ -86,8 +86,8 @@ class T_Options(TypedDict):
"enable_cftimeindex": True,
"file_cache_maxsize": 128,
"keep_attrs": "default",
"warn_for_unclosed_files": False,
"use_bottleneck": True,
"warn_for_unclosed_files": False,
}

_JOIN_OPTIONS = frozenset(["inner", "outer", "left", "right", "exact"])
Expand All @@ -110,8 +110,8 @@ def _positive_integer(value):
"enable_cftimeindex": lambda value: isinstance(value, bool),
"file_cache_maxsize": _positive_integer,
"keep_attrs": lambda choice: choice in [True, False, "default"],
"warn_for_unclosed_files": lambda value: isinstance(value, bool),
"use_bottleneck": lambda value: isinstance(value, bool),
"warn_for_unclosed_files": lambda value: isinstance(value, bool),
}


Expand Down Expand Up @@ -160,14 +160,14 @@ class set_options:
----------
arithmetic_join : {"inner", "outer", "left", "right", "exact"}, default: "inner"
DataArray/Dataset alignment in binary operations.
cmap_sequential : str or matplotlib.colors.Colormap, default: "viridis"
Colormap to use for nondivergent data plots. If string, must be
matplotlib built-in colormap. Can also be a Colormap object
(e.g. mpl.cm.magma)
cmap_divergent : str or matplotlib.colors.Colormap, default: "RdBu_r"
Colormap to use for divergent data plots. If string, must be
matplotlib built-in colormap. Can also be a Colormap object
(e.g. mpl.cm.magma)
cmap_sequential : str or matplotlib.colors.Colormap, default: "viridis"
Colormap to use for nondivergent data plots. If string, must be
matplotlib built-in colormap. Can also be a Colormap object
(e.g. mpl.cm.magma)
display_expand_attrs : {"default", True, False}:
Whether to expand the attributes section for display of
``DataArray`` or ``Dataset`` objects. Can be
Expand Down

0 comments on commit cc5a934

Please sign in to comment.