Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README badges, branch coverage #351

Closed
wants to merge 1 commit into from

Conversation

bollwyvl
Copy link
Collaborator

  • follow-on to Add codecov and coverage threshold, hoist test requirements to setup.py #348
  • mostly just want to see if we start getting the codecov PR comment, and if i can fix it with what perms i have...
  • adds the codecov badge (and friends) to README with links to various sources
  • enables branch coverage, which is slightly more pedantic about whether, e.g. a function with two separate if..elif..else statements executes the permutations of the full set

@bollwyvl
Copy link
Collaborator Author

Hm, the docs just talk about turning the PR comments off, or configuring it, not how to turn it on...

@bollwyvl bollwyvl closed this Mar 26, 2021
@bollwyvl bollwyvl reopened this Mar 26, 2021
@bollwyvl
Copy link
Collaborator Author

Ah, i had to turn on the app. I did so (because I could), but we can turn it off if we don't like it (or like having codecov have write access to PRs). Anyhow, we should at least see if the in-PR report will be useful.

The other approach is to have a dedicated oauth bot.

@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Mar 26, 2021

Hm, just kidding, no report for us. Well, at least we got badges. I guess we leave the app connected on for a sec, maybe it would start with new PRs? I'll try reopening this one...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant