Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: drop support for Sphinx 5 #1516

Merged
merged 2 commits into from
Oct 17, 2023
Merged

deps: drop support for Sphinx 5 #1516

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd64069
remove ref to myst-nb
12rambau Oct 17, 2023
c1c40c4
update minimal supported version of sphinx
12rambau Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions tools/github_actions_install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,8 @@ if [[ "$SPHINX_VERSION" == "" ]]; then
SPHINX_INSTALL=""
elif [[ "$SPHINX_VERSION" == "dev" ]]; then
SPHINX_INSTALL="git+https://github.com/sphinx-doc/sphinx"
if [[ "$1" == "doc" ]]; then
# Until they release a new version that undoes the max sphinx pin...
DEP_EXTRA="git+https://github.com/executablebooks/MyST-NB"
fi
elif [[ "$SPHINX_VERSION" == "old" ]]; then
SPHINX_INSTALL="sphinx==5.0"
SPHINX_INSTALL="sphinx==6.1.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this is pinned to 6.1.0 rather than the newer 6.2.1?

See ref: https://pypi.org/project/Sphinx/6.2.1/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our minimal requirement is coming from autoapi: sphinx>=6.1.0 so I set myself on this lowest pin.

else # not used currently but easy enough
SPHINX_INSTALL="sphinx==$SPHINX_VERSION"
fi
Expand Down
Loading