-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: change rational of the gallery grid #1390
Conversation
@12rambau I pushed some commits here:
If you strongly disagree with any of this it should be easy enough to revert the commits, I tried to keep the changes separated. Unfortunately now the CIs are failing everywhere due to nodeJS download errors, try re-triggering the CIs if you get a chance. (also I don't have permissions to re-trigger RTD builds, do you? If not just push an empty commit I guess) |
@drammock thanks for all your modifications, I liked it ! All tests are green so I'm going to merge this one ! |
Fix #1121
Choose who goes where
Refactoring
I didn't realized that the
gallery-grid
was used in so many places. I tried to improve compactness, documentation and logic (remove parameters that were legacy and not used).Docs
The rational is simple: people add their projects to the list at the bottom of the page (clicking on "Edit on Github" will do the trick) and fill the list. Then in a second step, if the maintainers agree that the project deserve biggest highlight (e.g. fancy customization), then we can promote it to the gallery file.
TODO
I'm not very satisfied with the wording in gallery.md feel free to update it.
Side note
I also realized that this directive is only working for MyST. I'm not a big fan of this as it prevents anybody to use it in a normal rst file. I'll open an issue for that later.
https://pydata-sphinx-theme--1390.org.readthedocs.build/en/1390/examples/gallery.html