Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idtracker.ai to gallery.yaml #1290

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Add idtracker.ai to gallery.yaml #1290

merged 2 commits into from
Sep 21, 2023

Conversation

jordi-torrents
Copy link
Contributor

I would like to add the website I've been working on to your example gallery.

@jordi-torrents
Copy link
Contributor Author

I just saw #1121, I will wait patiently for your resolution.

@drammock drammock added the needs: discussion Needs discussion before an implementation can be made label Jun 22, 2023
@12rambau
Copy link
Collaborator

12rambau commented Aug 1, 2023

@jordi-torrents, thanks for your patience, would you mind updating your branch so that idtracker.ai get into the list ? Note that you should set your site in alphabetical order.

@12rambau 12rambau removed the needs: discussion Needs discussion before an implementation can be made label Aug 1, 2023
@jordi-torrents
Copy link
Contributor Author

Sorry, I forgot about this. Is it ok like this?

@drammock
Copy link
Collaborator

looks like sphinx/docutils is auto-creating a link from the name of your package, making it look different than the others:

https://pydata-sphinx-theme--1290.org.readthedocs.build/en/1290/examples/gallery.html#other-projects-using-this-theme

We'll have to see if we can suppress this with CSS.

@drammock
Copy link
Collaborator

ok I've fixed the formatting mismatch in 7574511. Should be good to go once CIs finish.

@drammock
Copy link
Collaborator

looks good: https://pydata-sphinx-theme--1290.org.readthedocs.build/en/1290/examples/gallery.html#other-projects-using-this-theme

failing CIs are the perennial codecov upload problem; merging.

@drammock drammock merged commit 1741930 into pydata:main Sep 21, 2023
14 of 16 checks passed
@jordi-torrents jordi-torrents deleted the patch-1 branch September 21, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants