-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: refactor webpack.config.js #1035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple comments. I don't really understand how webpack works so I'm taking it on faith that you know what you're doing / the test will catch mistakes here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems pretty good to me in general - the preview docs seem pretty good to me, let's merge it in after addressing @drammock's comments and iterate from there?
Co-authored-by: Daniel McCloy <[email protected]>
Done
I'm no expert in webpack either but I'm positive that if something goes wrong (meaning the build of either css or js file fails) then the docs would not render properly in the pre-build. So I think we are on the safe side as everything went ok. |
I updated the file to make it more readable:
module.exports
to make it more readableFix #1030