-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: avoid API double select #1015
Conversation
On https://pydata-sphinx-theme.readthedocs.io/en/stable/examples/api.html#numpy.linalg.tensorinv If I double click A |
@AA-Turner on my side both I'm using safari but that's the same on firefox (MacOS Monterey) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@choldgraf are you on mac or windows? I tried with FF 105 originally (no issue), but having just now checked on chromium 106 the issue did appear--all testing on Windows 10. This seems like a HTML rendering engine difference -- with FF treating the A |
I'll merge this PR as it's solving our little problem and it is not creating issues for blink/webkit based browser. @AA-Turner if you want we can continue this conversation in sphinx-doc/sphinx#10815 to come up with a more robust solution. |
Thanks so much @12rambau ! :) |
I'm on windows 10 as well! |
It’s creating problems for us though. Just making a inline node display:flex is a very risky hack. |
could you elaborate on the risk you face due to our hack ? |
I meant “risky” in the sense of “likely to break”. Numpydoc’s definition lists happen to have markup that survives this, other code emitting definition lists probably doesn’t happen to create them just that way. |
Sure but I think a more robust solution should come from Sphinx itself |
Fix #388
Suprisingly 1 extra CSS rule was sufficient (my recent discovery on inline-blocks led me to this test and lucky for us it works like a charm.
I think it should be ported to sphinx attention but until then it does the job on our side.
exemplified in our doc here: https://pydata-sphinx-theme--1015.org.readthedocs.build/en/1015/examples/api.html#exceptions