Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Yahoo iCharts API #355

Merged
merged 24 commits into from
Jul 2, 2017
Merged

Replace Yahoo iCharts API #355

merged 24 commits into from
Jul 2, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Jul 2, 2017

supersedes #331

closes #315

  • fixes some issues with resources being closed (e.g. the session object).
  • remove deprecations of .ix -> replaced by .loc
  • remove deprecations of .sortlevel -> replaced by .sort_index
  • removes the _testing.py module; instead just uses xfails for RemoteDataException

rgkimball and others added 14 commits July 2, 2017 17:10
…stock still failing (#315)

Restores change necessary for Google to function
Fixes yahoo-actions per API endpoint update
Update regex pattern for crumbs, per heyuhere's review
'v' is no longer a valid interval value
Fixes Yahoo intervals and cases where the Yahoo cookie could not be extracted.
Implements multi-stock queries to Yahoo API
Adds a pause multiplier for subsequent requests from Yahoo, error handling for empty data requests, and updates some test logic for pandas 0.20.x (notably ix deprecation)
Check object type before checking contents
Replacement regex logic for additional Yahoo cookie token structures, per chris-b1
Improved error handling and refactoring test to best practices, per jreback review.

closes #315
remove deprecation warnings: sortlevel usage -> sort_index
@jreback jreback mentioned this pull request Jul 2, 2017
@bashtage bashtage deleted the rgkimball-fix-yahoo branch January 18, 2018 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with the data reader fetching yahoo finance
2 participants