Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env override nested vars #244

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

kschwab
Copy link
Contributor

@kschwab kschwab commented Feb 20, 2024

Resolves #241 and #203.

Updates deeply nested overrides to handle BaseModel derived types while ensuring copy-by-reference is maintained.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e5731a) 97.16% compared to head (f0bdc7f) 97.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   97.16%   97.26%   +0.09%     
==========================================
  Files           5        5              
  Lines         424      438      +14     
  Branches       90       95       +5     
==========================================
+ Hits          412      426      +14     
  Misses          9        9              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hramezani hramezani added the V3 label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.2.0 broke support for nested BaseSettings with base type (e.g. using ABC)
2 participants