✨ Implement optional number to str coercion
#975
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
==========================================
- Coverage 93.14% 93.11% -0.03%
==========================================
Files 106 106
Lines 15763 15791 +28
Branches 25 25
==========================================
+ Hits 14682 14704 +22
- Misses 1075 1081 +6
Partials 6 6
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
CodSpeed Performance ReportMerging #975 will not alter performanceComparing Summary
|
src/input/input_python.rs
Outdated
| // final output needs to be Python anyway. | ||
| Ok(s) => PyString::new(self.py(), s), | ||
| Err(_) => return Err(ValError::new(ErrorTypeDefaults::StringUnicode, self)), | ||
| }; | ||
| Ok(s.into()) | ||
| } else if coerce_numbers_to_str { | ||
| if let Ok(py_decimal) = self.lax_decimal(py) { |
There was a problem hiding this comment.
The downside of going through lax_decimal will be performance - you're creating a whole new Python decimal on the way.
There was a problem hiding this comment.
Yes, it is. We knew it will be less performant feature anyway.
It hits this only if it's not a string which is already the "bad" case and the alternative is hitting several TypeError exceptions. The alternative is to almost copy the lax_decimal code.
I'll give it another try.
There was a problem hiding this comment.
Implemented using just isinstance calls.
lig
force-pushed
the
lig/6045-v2-validating-int-str
branch
from
0c44176
to
e0c3432
Compare
lig
force-pushed
the
lig/6045-v2-validating-int-str
branch
from
9ec8778
to
3156a08
Compare
|
please review |
|
please update |
Co-authored-by: David Hewitt <[email protected]>
Co-authored-by: David Hewitt <[email protected]>
|
please review |
Change Summary
Implement optional
numbertostrcoercionRelated issue number
See pydantic/pydantic#6045
Checklist
pydantic-core(except for expected changes)Selected Reviewer: @davidhewitt