Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to coverage_attribute feature #966

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Sep 18, 2023

Change Summary

Fixes CI issues after upstream nightly change rust-lang/rust#114656

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #966 (67c3cff) into main (f6b14cc) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #966   +/-   ##
=======================================
  Coverage   93.80%   93.80%           
=======================================
  Files         105      105           
  Lines       15468    15468           
  Branches       25       25           
=======================================
  Hits        14510    14510           
  Misses        952      952           
  Partials        6        6           
Files Changed Coverage Δ
src/build_tools.rs 81.63% <ø> (ø)
src/input/input_abstract.rs 90.40% <ø> (ø)
src/input/input_json.rs 91.83% <ø> (ø)
src/lib.rs 100.00% <ø> (ø)
src/tools.rs 97.50% <ø> (ø)
src/input/parse_json.rs 96.34% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5edddd5...67c3cff. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 18, 2023

CodSpeed Performance Report

Merging #966 will improve performances by 12.81%

Comparing dh/coverage-attribute (67c3cff) with main (5edddd5)

Summary

⚡ 3 improvements
✅ 135 untouched benchmarks

Benchmarks breakdown

Benchmark main dh/coverage-attribute Change
test_core_string_strict_wrong 50.4 µs 44.7 µs +12.81%
test_small_class_core_model 54.5 µs 48.4 µs +12.63%
test_validate_literal[python-few_mixed] 32.9 µs 29.3 µs +12.19%

@davidhewitt
Copy link
Contributor Author

please review

@davidhewitt davidhewitt merged commit 3dfecd7 into main Sep 18, 2023
30 checks passed
@davidhewitt davidhewitt deleted the dh/coverage-attribute branch September 18, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants