Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 's lifetime from validate and validate_assignment #890

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Aug 16, 2023

Change Summary

As far as I can tell, not necessary and just increases cognitive load :)

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@davidhewitt
Copy link
Contributor Author

please review

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #890 (94ff004) into main (2e59f25) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
- Coverage   93.79%   93.78%   -0.01%     
==========================================
  Files         105      105              
  Lines       15252    15249       -3     
  Branches       25       25              
==========================================
- Hits        14305    14302       -3     
  Misses        941      941              
  Partials        6        6              
Files Changed Coverage Δ
src/validators/is_subclass.rs 80.95% <ø> (ø)
src/validators/literal.rs 92.80% <ø> (ø)
src/validators/any.rs 100.00% <100.00%> (ø)
src/validators/arguments.rs 100.00% <100.00%> (ø)
src/validators/bool.rs 100.00% <100.00%> (ø)
src/validators/bytes.rs 91.11% <100.00%> (ø)
src/validators/call.rs 93.93% <100.00%> (ø)
src/validators/callable.rs 100.00% <100.00%> (ø)
src/validators/chain.rs 84.12% <100.00%> (ø)
src/validators/custom_error.rs 87.32% <100.00%> (ø)
... and 31 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e59f25...94ff004. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 16, 2023

CodSpeed Performance Report

Merging #890 will not alter performance

Comparing dh/remove-lifetimes (94ff004) with main (2e59f25)

Summary

✅ 138 untouched benchmarks

@davidhewitt davidhewitt merged commit a2b531a into main Aug 16, 2023
29 of 30 checks passed
@davidhewitt davidhewitt deleted the dh/remove-lifetimes branch August 16, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants